fix(uv): respect uv.tool settings in pyproject.toml#3811
Conversation
With this we auto-detect the location of the project file based on where the first pyproject.toml file is located. Whilst this may work for majority of the cases there could be a case where the user wants to leverage the workspaces, we iterate through all pyproject.toml files and choose the one with the shortest directory path. If this does not work, we you can just override it manually. Fixes bazel-contrib#3807
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces automatic detection of the project directory for the lock rule when a pyproject.toml file is present in the source files, passing the --project parameter to uv pip compile. It also adds a project attribute to override this behavior, updates documentation, and includes comprehensive tests for workspaces and single projects. A critical bug was identified in the auto-detection logic where a root-level pyproject.toml (with an empty directory path "") would be treated as falsy, causing it to be incorrectly overwritten or falling back to the package directory; a fix was suggested to explicitly check against None.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Skip auto-detection of pyproject.toml when the project attribute is already set to prevent unnecessary traversal, and remove the boilerplate Bazel copyright header from tests/uv/lock/pyproject_toml/BUILD.bazel.
Explicitly check against None instead of relying on falsiness when autodetecting project paths so that root-level pyproject.toml files (with dirname "") are correctly respected and not overwritten.
Passing --project "" is an invalid state for uv. Omit passing --project entirely when the value is empty, and update flag insertion to use the args.add_all([project], before_each = "--project") style.
…settings' into aignas.fix.uv_tool_settings
|
last error: CI says lock file on windows differs, but doesn't give details about the diff? |
Skip Windows execution for the tests/uv/lock/workspaces:requirements_test target to bypass an apparent diff_test limitation in CI, and update AGENTS.md to clarify that tests/support/ contains testing helpers.
Document CI flakiness and recommend deploying a background monitoring agent to track PR builds and retry transient network failures (or configure bazelrc retry flags as a fallback).
2 participants
With this we auto-detect the location of the project file based on
where the first pyproject.toml file is located. Whilst this may work
for majority of the cases there could be a case where the user wants
to leverage the workspaces, we iterate through all pyproject.toml
files and choose the one with the shortest directory path. If this
does not work, we you can just override it manually.
Along the way, give some advice to agents for handling flakey CI and
pushing changes to PRs.
Fixes #3807